Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default assignee only if category is not specified or it doesn't have a default assignee itself #33

Closed
wants to merge 4 commits into from
Closed

use default assignee only if category is not specified or it doesn't have a default assignee itself #33

wants to merge 4 commits into from

Conversation

piccio
Copy link

@piccio piccio commented May 19, 2016

#30
use default assignee only if category is not specified or it doesn't have a default assignee itself

@giddie
Copy link
Owner

giddie commented May 19, 2016

Thanks for doing this work :)

giddie
giddie reviewed May 19, 2016
View reviewed changes
app/views/settings/_default_assign.erb
-%>
<%= hidden_field_tag('settings[self_assignment]', false) %>
<%= check_box_tag('settings[self_assignment]', true, self_assignment) %>
</p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why the indentation has changed here? Looks like it might have gained a space?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that 2 spaces indentation is a ruby best practice
https://github.com/bbatsov/ruby-style-guide#source-code-layout

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, was there only 1 previously? If so, could you re-indent the whole file a separate commit, so that the code changes don't get lost in the whitespace change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I'm sorry I'm hurry

@giddie
Copy link
Owner

giddie commented May 19, 2016 •
edited
Loading

OK, I've tested this, and I'm quite confused: for me, in non-interactive mode, the category assignee is set before #assign_default_assignee is called, and because an assignee is already set, it returns early. So in non-interactive mode, the plugin already has no effect by default. Is this pull request intended to enable the plugin to forcibly override the default specified by the category on issue creation? (If so, I think that would be of limited use: you could simply remove the category default assignee instead.)

Can you explain what the desired behaviour is in interactive mode?

@piccio
Copy link
Author

piccio commented May 20, 2016

sorry reset all
I were working on an old version where the default assignee override the category's assignee.
In the last version this beaviour doesn't occour.

@piccio piccio closed this May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piccio @giddie